Addressing review comments

hashicorp · Jun 7, 2023 · 9f396c3 · 9f396c3
1 parent 14fa790
commit 9f396c3
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/control-plane/catalog/to-consul/resource.go b/control-plane/catalog/to-consul/resource.go
@@ -513,7 +513,7 @@ func (t *ServiceResource) generateRegistrations(key string) {
 			r.Service.Address = ip
 			// Adding information about service weight.
 			// Overrides the existing weight if present
-			if weight, ok := svc.Annotations[annotationServiceWeight]; ok || weight != "" {
+			if weight, ok := svc.Annotations[annotationServiceWeight]; ok && weight != "" {
 				err := setServiceWeight(weight, len(ips), &r)
 				if err != nil {
 					t.Log.Debug("assertion: The service with ",
@@ -561,7 +561,7 @@ func (t *ServiceResource) generateRegistrations(key string) {
 
 				// Adding information about service weight.
 				// Overrides the existing weight if present
-				if weight, ok := svc.Annotations[annotationServiceWeight]; ok || weight != "" {
+				if weight, ok := svc.Annotations[annotationServiceWeight]; ok && weight != "" {
 					ingress_count := len(svc.Status.LoadBalancer.Ingress)
 					err := setServiceWeight(weight, ingress_count, &r)
 					if err != nil {