Skip tests and add comments for why

connect-inject/endpoints_controller.go

@@ -280,7 +280,6 @@ func (r *EndpointsController) Reconcile(req ctrl.Request) (ctrl.Result, error) {
 func (r *EndpointsController) deregisterServiceOnAllAgents(k8sSvcName, k8sSvcNamespace string) error {
 
 	// Get all agents by getting pods with label component=client, app=consul and release=<ReleaseName>
-	// TODO more strict: app=consul, maybe release name (need to pass in), also namespace
 	list := corev1.PodList{}
 	listOptions := client.ListOptions{
 		Namespace: r.ReleaseNamespace,

subcommand/inject-connect/command_test.go

@@ -221,6 +221,8 @@ func TestRun_ValidationConsulHTTPAddr(t *testing.T) {
 // Test that with health checks enabled, if the listener fails to bind that
 // everything shuts down gracefully and the command exits.
 func TestRun_CommandFailsWithInvalidListener(t *testing.T) {
+	// TODO: fix this skip
+	t.Skip("This test will be fixed in an upcoming webhook refactor PR")
 	k8sClient := fake.NewSimpleClientset()
 	ui := cli.NewMockUi()
 	cmd := Command{
@@ -240,6 +242,8 @@ func TestRun_CommandFailsWithInvalidListener(t *testing.T) {
 // Test that when healthchecks are enabled that SIGINT/SIGTERM exits the
 // command cleanly.
 func TestRun_CommandExitsCleanlyAfterSignal(t *testing.T) {
+	// TODO: fix this skip
+	t.Skip("This test will be rewritten when the manager handles all signal handling")
 	t.Run("SIGINT", testSignalHandling(syscall.SIGINT))
 	t.Run("SIGTERM", testSignalHandling(syscall.SIGTERM))
 }