-
Notifications
You must be signed in to change notification settings - Fork 324
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Backport of add linting back into release/1.4.x (#3608)
backport of commit c1d36c6 Co-authored-by: Michael Wilkerson <mwilkerson@hashicorp.com>
- Loading branch information
1 parent
6fe4bc7
commit d5e1361
Showing
1 changed file
with
68 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
# Dispatch to the consul-k8s-workflows when a PR is created and on merges to main/release* | ||
name: lint | ||
on: | ||
pull_request: | ||
|
||
jobs: | ||
get-go-version: | ||
runs-on: ubuntu-latest | ||
outputs: | ||
go-version: ${{ steps.get-go-version.outputs.go-version }} | ||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3 | ||
|
||
- name: Determine Go version | ||
id: get-go-version | ||
# We use .go-version as our source of truth for current Go | ||
# version, because "goenv" can react to it automatically. | ||
run: | | ||
echo "Building with Go $(cat .go-version)" | ||
echo "go-version=$(cat .go-version)" >> "${GITHUB_OUTPUT}" | ||
linting: | ||
name: golangci-lint | ||
needs: | ||
- get-go-version | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3 | ||
|
||
- name: Setup go | ||
uses: actions/setup-go@fac708d6674e30b6ba41289acaab6d4b75aa0753 # v4.0.1 | ||
with: | ||
go-version: ${{ needs.get-go-version.outputs.go-version }} | ||
cache: false | ||
|
||
- name: Setup GOROOT # Need to set GOROOT because an older version of go-critic used GOROOT to find rules | ||
run: echo "GOROOT=$(go env GOROOT)" >> "${GITHUB_ENV}" | ||
|
||
- name: golangci-lint-helm-gen | ||
uses: golangci/golangci-lint-action@639cd343e1d3b897ff35927a75193d57cfcba299 # v3.6.0 | ||
with: | ||
version: "v1.55.2" | ||
working-directory: hack/helm-reference-gen | ||
skip-cache: true # We have seen sticky timeout bugs crop up with caching enabled, so disabling for now | ||
args: "--no-config --disable-all --enable gofmt,govet" | ||
|
||
- name: golangci-lint-control-plane | ||
uses: golangci/golangci-lint-action@639cd343e1d3b897ff35927a75193d57cfcba299 # v3.6.0 | ||
with: | ||
version: "v1.55.2" | ||
working-directory: control-plane | ||
skip-cache: true # We have seen sticky timeout bugs crop up with caching enabled, so disabling for now | ||
|
||
- name: golangci-lint-acceptance | ||
uses: golangci/golangci-lint-action@639cd343e1d3b897ff35927a75193d57cfcba299 # v3.6.0 | ||
with: | ||
version: "v1.55.2" | ||
working-directory: acceptance | ||
skip-cache: true # We have seen sticky timeout bugs crop up with caching enabled, so disabling for now | ||
|
||
- name: golangci-lint-cli | ||
uses: golangci/golangci-lint-action@639cd343e1d3b897ff35927a75193d57cfcba299 # v3.6.0 | ||
with: | ||
version: "v1.55.2" | ||
working-directory: acceptance | ||
skip-cache: true # We have seen sticky timeout bugs crop up with caching enabled, so disabling for now |