-
Notifications
You must be signed in to change notification settings - Fork 321
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Always update auth method. Previously, we would only update auth method in Consul if Consul namespaces are enabled. This was necessary to make sure that if namespace configuration changes, it is reflected in the auth method. However, running Consul servers externally is another use case of why it's important to update the auth method. That is because if you run a Helm install, then uninstall and install again, the auth method saved in Consul will be out-of-date: it will have the service account JWT token saved in the auth method refers to the service account token that has been deleted from Kubernetes when you ran helm uninstall. This change proposes to always update the auth method to solve for the external servers use case.
- Loading branch information
Showing
3 changed files
with
164 additions
and
99 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters