Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-allow-k8s-namespace and -deny-k8s-namespace flags ignored #296

Closed
lkysow opened this issue Jul 20, 2020 · 0 comments · Fixed by #297
Closed

-allow-k8s-namespace and -deny-k8s-namespace flags ignored #296

lkysow opened this issue Jul 20, 2020 · 0 comments · Fixed by #297
Assignees
@adilyse
Labels
area/connect Related to Connect service mesh, e.g. injection type/bug Something isn't working

Comments

@lkysow
Copy link
Member

lkysow commented Jul 20, 2020

If -enable-namespaces is not set then we ignore the -allow-k8s-namespace and -deny-k8s-namespace flags. -enable-namespaces is only set for Consul Enterprise but the allow/deny flags for k8s namespaces shouldn't require Consul Enterprise namespaces.

https://github.com/hashicorp/consul-k8s/blob/master/connect-inject/handler.go#L385-L395
@lkysow lkysow added type/bug Something isn't working area/connect Related to Connect service mesh, e.g. injection labels Jul 20, 2020
adilyse added a commit that referenced this issue Jul 20, 2020
@adilyse
Respect allow/deny lists even when namespaces aren't enabled
7dc0d15 
Fixes #296
@adilyse adilyse mentioned this issue Jul 20, 2020
Merged
adilyse added a commit that referenced this issue Jul 21, 2020
@adilyse
Respect allow/deny lists even when namespaces aren't enabled
ba63098 
Fixes #296
@adilyse adilyse self-assigned this Jul 21, 2020
adilyse added a commit that referenced this issue Jul 21, 2020
@adilyse
Respect allow/deny lists even when namespaces aren't enabled
34896cb 
Fixes #296
ndhanushkodi pushed a commit to ndhanushkodi/consul-k8s that referenced this issue Jul 9, 2021
@lkysow
Merge pull request hashicorp#296 from hashicorp/contributing
534cc0c 
Move contributing docs to contributing.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adilyse adilyse

Labels
area/connect Related to Connect service mesh, e.g. injection type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Respect allow/deny lists even when namespaces aren't enabled hashicorp/consul-k8s
2 participants
@lkysow @adilyse