fix(control-plane): sidecar CPU limit incorrectly validated against CPU request #3209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zalimeni
approved these changes
Nov 13, 2023
DanStough
force-pushed
the
dans/fix-CPU-request-validation
branch
from
b35f844
to
78db847
Compare
2 tasks
jjti
pushed a commit
that referenced
this pull request
Nov 14, 2023
sarahalsmiller
pushed a commit
that referenced
this pull request
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3205
Changes proposed in this PR:
How I've tested this PR:
The test only validated failure cases and I didn't think it was the effort to create a new suite that test successful cross-validation of memory and CPU allocations.
How I expect reviewers to test this PR: 👀
Checklist:
Tests added