Backport of fix(control-plane): sidecar CPU limit incorrectly validated against CPU request into release/1.3.x #3212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/dans/fix-CPU-request-validation/nicely-smiling-gazelle
branch
from
ad84047
to
c446f85
Compare
hc-github-team-consul-core
force-pushed
the
backport/dans/fix-CPU-request-validation/nicely-smiling-gazelle
branch
from
f7b949a
to
a5ac442
Compare
david-yu
approved these changes
Nov 14, 2023
hc-github-team-consul-core
merged commit 36898a2
into
release/1.3.x
43 of 49 checks passed
hc-github-team-consul-core
deleted the
backport/dans/fix-CPU-request-validation/nicely-smiling-gazelle
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #3209 to be assessed for backporting due to the inclusion of the label backport/1.3.x.
The below text is copied from the body of the original PR.
Fixes #3205
Changes proposed in this PR:
How I've tested this PR:
The test only validated failure cases and I didn't think it was the effort to create a new suite that test successful cross-validation of memory and CPU allocations.
How I expect reviewers to test this PR: 👀
Checklist:
Tests addedOverview of commits