Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NET-10548 Adds image pull secrets to the gateway cleanup and gateway resources job service account #4210

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

missylbytes
Copy link
Contributor

@missylbytes missylbytes commented Jul 25, 2024

This fixes #3862. When installing consul-k8s with a private image registry, the 'gateway-resources' and 'gateway-cleanup jobs could not pull the images as thier service accounts did not include the imagePull secrets

How I've tested this PR

  • Added bats test
  • Manually tested with the following values and a private registry set up
    Do a helm install with the local chart from this branch. If the jobs didn't have the required pull secrets, they would never spin up.
    Also do a helm uninstall to see the cleanup-job run.
global:
  name: consul
  imageK8S: my-private-registry/consul-k8s-control-plane:latest
  imagePullSecrets:
  - name: consul-pull-secret
    namespace: consul
# This is useful to make sure it is always pulling the image, and not just getting it from another container on the cluster
  imagePullPolicy: "Always" 

How I expect reviewers to test this PR

Test on your own cluster with a private registry using the above values.

Checklist

@missylbytes missylbytes added backport/1.4.x backport/1.5.x backport/1.3.x This release branch is no longer active. backport/1.2.x This release branch is no longer active. labels Jul 25, 2024
@missylbytes missylbytes requested review from a team, NiniOak and xwa153 and removed request for a team July 25, 2024 18:18
@missylbytes missylbytes marked this pull request as ready for review July 25, 2024 18:18
@missylbytes missylbytes removed the backport/1.2.x This release branch is no longer active. label Jul 25, 2024
@missylbytes missylbytes changed the title Adds image pull secrets to the gateway cleanup and gateway resources job service account NET-10548 Adds image pull secrets to the gateway cleanup and gateway resources job service account Jul 25, 2024
@missylbytes missylbytes merged commit 7a34565 into main Jul 29, 2024
50 checks passed
@missylbytes missylbytes deleted the add-imagepullsecret-to-gatewayresources branch July 29, 2024 14:15
missylbytes added a commit that referenced this pull request Jul 29, 2024
hc-github-team-consul-core added a commit that referenced this pull request Jul 29, 2024
…and gateway resources job service account into release/1.3.x (#4216)

NET-10548 Adds image pull secrets to the gateway cleanup and gateway resources job service account (#4210)

Co-authored-by: Melisa Griffin <missylbytes@users.noreply.github.com>
@pawellegowski89
Copy link

#3862 the error has not been fixed. Version 1.19.2, chart 1.5.3 still affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.3.x This release branch is no longer active. backport/1.4.x backport/1.5.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gateway-resources service account missing imagePullSecrets
3 participants