Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of NET-10548 Adds image pull secrets to the gateway cleanup and gateway resources job service account into release/1.5.x #4218

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #4210 to be assessed for backporting due to the inclusion of the label backport/1.5.x.

The below text is copied from the body of the original PR.


This fixes #3862. When installing consul-k8s with a private image registry, the 'gateway-resources' and 'gateway-cleanup jobs could not pull the images as thier service accounts did not include the imagePull secrets

How I've tested this PR

  • Added bats test
  • Manually tested with the following values and a private registry set up
    Do a helm install with the local chart from this branch. If the jobs didn't have the required pull secrets, they would never spin up.
    Also do a helm uninstall to see the cleanup-job run.
global:
  name: consul
  imageK8S: my-private-registry/consul-k8s-control-plane:latest
  imagePullSecrets:
  - name: consul-pull-secret
    namespace: consul
# This is useful to make sure it is always pulling the image, and not just getting it from another container on the cluster
  imagePullPolicy: "Always" 

How I expect reviewers to test this PR

Test on your own cluster with a private registry using the above values.

Checklist


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core merged commit 291754b into release/1.5.x Jul 29, 2024
49 checks passed
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/add-imagepullsecret-to-gatewayresources/usefully-amazing-deer branch July 29, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants