Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HOST_IP environment variable to consul_dataplane_sidecar.go #4277

Merged
merged 10 commits into from
Aug 30, 2024

Conversation

nathancoleman
Copy link
Member

Note

This is sourced from #3916. I needed to open here so that CI requiring tokens that are unavailable in forks can run

Changes proposed in this PR

  • Add HOST_IP environment variable to consul_dataplane_sidecar.go

This environment variable must be set in order to utilize HOST_IP as part of statsd or dogstatsd sinks. If this variable is unset and the sink is configured to use HOST_IP, the sidecar won't start and pods won't come up healthy.

How I've tested this PR

  • Unit tests
  • Deployed and tested a local build to our cluster and confirmed that injected pods now come up healthy and have the HOST_IP variable set as expected

How I expect reviewers to test this PR

  • The unit tests should do it

    Reference to similar change for mesh-gateway deployments:

Checklist

woz5999 and others added 9 commits April 16, 2024 14:07
This environment variable must be set in order to utilize HOST_IP as part of statsd or dogstatsd sinks. If this variable is unset and the sink is configured to use HOST_IP, the sidecar won't start and pods won't coe up healthy.
Co-authored-by: Nathan Coleman <nathandanielcoleman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants