Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Add HOST_IP environment variable to consul_dataplane_sidecar.go into release/1.5.x #4285

Open
wants to merge 7 commits into
base: release/1.5.x
Choose a base branch
from

Conversation

hc-github-team-consul-core
Copy link
Collaborator

@hc-github-team-consul-core hc-github-team-consul-core commented Aug 30, 2024

Backport

This PR is auto-generated from #4277 to be assessed for backporting due to the inclusion of the label backport/1.5.x.

The below text is copied from the body of the original PR.


Note

This is sourced from #3916. I needed to open here so that CI requiring tokens that are unavailable in forks can run

Changes proposed in this PR

  • Add HOST_IP environment variable to consul_dataplane_sidecar.go

This environment variable must be set in order to utilize HOST_IP as part of statsd or dogstatsd sinks. If this variable is unset and the sink is configured to use HOST_IP, the sidecar won't start and pods won't come up healthy.

How I've tested this PR

  • Unit tests
  • Deployed and tested a local build to our cluster and confirmed that injected pods now come up healthy and have the HOST_IP variable set as expected

How I expect reviewers to test this PR

  • The unit tests should do it

    Reference to similar change for mesh-gateway deployments:

Checklist


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/woz5999/sidecar-host-ip/mainly-bold-shepherd branch from 7de827f to 072a193 Compare August 30, 2024 17:26
@nathancoleman nathancoleman marked this pull request as ready for review August 30, 2024 20:14
@nathancoleman nathancoleman force-pushed the backport/woz5999/sidecar-host-ip/mainly-bold-shepherd branch from 072a193 to 9d737bb Compare August 30, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants