Allow API Gateway controller to update k8s Deployments + Services #1014
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The k8s client abstraction in consul-api-gateway expects to be able to create or update k8s
Deployments
andServices
; however, theClusterRole
as defined today does not allow for updates to these resources. This prevents the Consul API Gateway controller from successfully installing a new gateway to the cluster.Changes proposed in this PR:
ClusterRole
to allow controller to update k8sDeployment
ClusterRole
to allow controller to update k8sService
How I've tested this PR:
Applied changes to deployment on GKE
How I expect reviewers to test this PR:
Follow the Learn tutorial for Consul API Gateway; however, the Consul Helm chart install needs to use the branch in this PR.
I believe the easiest way to do that is to check this branch out locally and
$ helm install ...
from there (replacing$ helm install --values consul/config.yaml consul hashicorp/consul --version "0.40.0"
with the following):Checklist: