Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect CRD field names #1017

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Fix incorrect CRD field names #1017

merged 2 commits into from
Feb 3, 2022

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Feb 3, 2022 •
edited
Loading

gatewayTLSConfig => tls
gatewayTLSSDSConfig => sds

How I've tested this PR:

  • s/old/new/g

How I expect reviewers to test this PR:

  • code

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@lkysow
Fix incorrect CRD field names
a2facee 
gatewayTLSConfig => tls
gatewayTLSSDSConfig => sds
thisisnotashwin
thisisnotashwin approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 thanks for doing this

@lkysow lkysow marked this pull request as ready for review February 3, 2022 18:38
@lkysow lkysow requested review from a team, kschoche and ishustava and removed request for a team February 3, 2022 18:43
@lkysow lkysow merged commit 2e7c611 into main Feb 3, 2022
@lkysow lkysow deleted the lkysow/api-gateway-sds branch February 3, 2022 21:36
jmurret pushed a commit that referenced this pull request Feb 4, 2022
@lkysow @jmurret
Fix incorrect CRD field names (#1017)
b57d5b7 
* Fix incorrect CRD field names

gatewayTLSConfig => tls
gatewayTLSSDSConfig => sds
geobeau pushed a commit to geobeau/consul-k8s that referenced this pull request May 20, 2022
@lkysow
Update Helm docs generation (hashicorp#1017)
71b16eb 
Add headings to each top-level key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisnotashwin thisisnotashwin thisisnotashwin approved these changes

@ishustava ishustava ishustava approved these changes

@kschoche kschoche Awaiting requested review from kschoche

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lkysow @ishustava @thisisnotashwin