Sync catalog acl refactor #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisnotashwin
changed the base branch from
main
to
connect-inject-acl-refactor
thisisnotashwin
force-pushed
the
connect-inject-acl-refactor
branch
2 times, most recently
from
61e651f to
5ba54b2
Compare
thisisnotashwin
force-pushed
the
sync-token-acl-refactor
branch
from
0550da1 to
d68a844
Compare
thisisnotashwin
requested review from
ishustava and
kschoche
and removed request for
ishustava
thisisnotashwin
force-pushed
the
connect-inject-acl-refactor
branch
from
5ba54b2 to
41b5fe3
Compare
thisisnotashwin
force-pushed
the
sync-token-acl-refactor
branch
10 times, most recently
from
6fdd05a to
b082126
Compare
thisisnotashwin
force-pushed
the
connect-inject-acl-refactor
branch
5 times, most recently
from
e136832 to
58d6bf4
Compare
thisisnotashwin
force-pushed
the
sync-token-acl-refactor
branch
from
b082126 to
a25a183
Compare
ishustava
approved these changes
Mar 7, 2022
| - serviceaccounts | ||
| verbs: | ||
| - get | ||
| {{- end }} |
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRole | ||
| metadata: | ||
| name: {{ template "consul.fullname" . }}-authmethod |
There was a problem hiding this comment.
nit: should it be auth-method?
Comment on lines
-43
to
44
| {{- if .Values.global.acls.manageSystemACLs }} | ||
| - apiGroups: [""] | ||
| resources: | ||
| - serviceaccounts | ||
| verbs: | ||
| - get | ||
| {{- end }} |
There was a problem hiding this comment.
I think we might need this for multiport
There was a problem hiding this comment.
I noticed that those lines were duplicated 😅
but we definitely need it for the multiport workaround..i found out the acceptance tests failed on me way
Comment on lines
+22
to
+23
| #-------------------------------------------------------------------- | ||
| # global.imagePullSecrets |
There was a problem hiding this comment.
Thinking about it, I don't think we need imagePullSecrets for this SA because it's not used by any pod, but maybe worth keeping just in case?
Comment on lines
+129
to
+130
| c.flags.BoolVar(&c.flagEnableCatalogSync, "sync-catalog", false, | ||
| "Toggle for creating a catalog sync policy.") |
There was a problem hiding this comment.
nit: I think it'd be nice for flag name and var name to match for readablity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: