Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug when upgrading from non-mesh to mesh #1136

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Fix bug when upgrading from non-mesh to mesh #1136

merged 1 commit into from
Apr 13, 2022

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Apr 1, 2022 •
edited
Loading

Changes proposed in this PR:

How I've tested this PR:

  • unit tests
  • built an image and tested

How I expect reviewers to test this PR:

  • code

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@lkysow lkysow force-pushed the lkysow/mesh-upgrade-bug branch 4 times, most recently from b303dbe to db7978e Compare April 4, 2022 22:07
@lkysow lkysow requested review from ishustava, a team and t-eckert and removed request for ishustava and a team April 4, 2022 22:29
@lkysow lkysow marked this pull request as ready for review April 4, 2022 22:29
ishustava
ishustava approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@lkysow
Fix bug upgrading from non-mesh to mesh
7729f10 
When modifying a deployment to add it to the mesh, there will be a
time when the endpoints list has both non-injected and injected
pods. Previously we were short-circuiting in this case which
meant the injected pods never got registered.
@lkysow lkysow force-pushed the lkysow/mesh-upgrade-bug branch from 882c37a to 7729f10 Compare April 12, 2022 20:22
@lkysow lkysow merged commit 4a4f555 into main Apr 13, 2022
@lkysow lkysow deleted the lkysow/mesh-upgrade-bug branch April 13, 2022 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-eckert t-eckert t-eckert approved these changes

@ishustava ishustava ishustava approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't add connect inject annotation to existing deployment
3 participants
@lkysow @ishustava @t-eckert