Fix cli to work on windows #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkysow
commented
Apr 4, 2022
| @@ -86,11 +93,7 @@ func readFile(chart embed.FS, f string, pathPrefix string) (*loader.BufferedFile | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| // Remove the path prefix. | |||
There was a problem hiding this comment.
Rel() doesn't exist in the path package. I looked at copying it from filepath but it uses a lot of internal stuff to filepath so not an easy copy. I think we're okay just trimming the prefix here because we're always passing in pathPrefix (hence variable name), not something we need to properly calculate the relative directory of.
t-eckert
approved these changes
Apr 4, 2022
lkysow
requested review from
a team,
jmurret and
ishustava
and removed request for
a team
Previously would error about missing file `consul\Chart.yaml`. This is because the go embedded filesystem must be accessed using `/` delimiters but we were using `filepath` functions which on windows use `\`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously would error about missing file
consul\Chart.yaml. Thisis because the go embedded filesystem must be accessed using
/delimiters but we were using
filepathfunctions which on windowsuse
\.How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: