-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable configure Connect Injector and Controller Webhooks to be managed by Vault #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmurret
force-pushed
the
jm/webhook-certs
branch
3 times, most recently
from
May 9, 2022 16:45
0f8b32b
to
a86a5d5
Compare
1 task
jmurret
force-pushed
the
jm/webhook-certs
branch
2 times, most recently
from
May 19, 2022 21:28
a77cdce
to
2990896
Compare
jmurret
changed the base branch from
jm/refactor-vault-tests
to
jm/vault-test-refactor
May 19, 2022 21:29
jmurret
force-pushed
the
jm/vault-test-refactor
branch
from
May 19, 2022 21:30
f7e6353
to
32f54f5
Compare
jmurret
commented
May 22, 2022
jmurret
commented
May 22, 2022
jmurret
commented
May 22, 2022
jmurret
commented
May 22, 2022
jmurret
commented
May 22, 2022
jmurret
commented
May 22, 2022
jmurret
commented
May 22, 2022
control-plane/helper/mutating-webhook-configuration/mutating_webhook_configuration.go
Show resolved
Hide resolved
jmurret
commented
May 22, 2022
jmurret
commented
May 22, 2022
jmurret
commented
May 23, 2022
jmurret
commented
May 23, 2022
jmurret
commented
May 23, 2022
jmurret
commented
May 23, 2022
jmurret
commented
May 23, 2022
jmurret
commented
May 23, 2022
jmurret
commented
May 23, 2022
jmurret
commented
May 23, 2022
… TestVault_WebhookCerts test
…ronnectInjectCARole to consulConnectInjectRole
… the same as they are under web-cert-manager. updated path of where webhook certs get saved.
…k cert specific test.
…iable for readability
Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
…lane/subcommand/controller/command.go Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
jmurret
force-pushed
the
jm/webhook-certs
branch
from
June 13, 2022 18:23
f3241e9
to
21c2ee7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How to read this PR:
charts/consul/values.yaml
to get a sense of what is exposedacceptance/tests/vault/vault_webhook_certs_test.go
and the comments left therecharts/consul/templates/connect-inject-deployment.yaml
andcharts/consul/templates/controller-deployment.yaml
to see how configuration is passedcontrol-plane/subcommand/controller/command.go
control-plane/subcommand/inject-connect/command.go
control-plane/subcommand/webhook-cert-manager/command.go
How I've tested this PR:
How I expect reviewers to test this PR:
👀
Checklist: