Revert 1.12 TLS config to ensure 1.11 image is also supported. #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisnotashwin
force-pushed
the
ashwin/revert-tls-config
branch
from
cfc93e0 to
387d27a
Compare
- Revert this commit when we want to stop supporting 1.11 style TLS config.
thisisnotashwin
force-pushed
the
ashwin/revert-tls-config
branch
from
387d27a to
28c4e3f
Compare
thisisnotashwin
requested review from
a team,
jmurret and
kschoche
and removed request for
a team
kschoche
reviewed
May 11, 2022
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| BREAKING CHANGES: | |||
| * Helm | |||
| * Using the Vault integration requires Consul 1.12.0+. [[GH-1213](https://github.com/hashicorp/consul-k8s/pull/1213)] | |||
| * Using the Vault integration requires Consul 1.12.0+. [[GH-1213](https://github.com/hashicorp/consul-k8s/pull/1213)], [[GH-1218](https://github.com/hashicorp/consul-k8s/pull/1218)] | |||
There was a problem hiding this comment.
Sorry not trying to be nitpicky here, but should we specify if this is Vault as the connect-ca, or the vault secrets backend or both?
There was a problem hiding this comment.
I think most users who are using Vault for either will be ok migrating to 1.12 which is why this was left generic.
kschoche
reviewed
May 11, 2022
| {{- end }} | ||
| } | ||
| }, | ||
| {{- if .Values.global.secretsBackend.vault.enabled }} |
There was a problem hiding this comment.
This might be my browser but it looks like the indentation is off for these two blocks. I don't think it makes a functional difference tho with JSON?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: