Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add vault agent annotations to apigw #1247

Merged
merged 2 commits into from
May 27, 2022
Merged

add vault agent annotations to apigw #1247

merged 2 commits into from
May 27, 2022

Conversation

kschoche
Copy link
Contributor

Changes proposed in this PR:

How I've tested this PR:
bats tests

How I expect reviewers to test this PR:
👀

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@kschoche kschoche added vault theme/api-gateway Related to Consul API Gateway labels May 27, 2022
@kschoche kschoche requested review from nickethier and a team May 27, 2022 04:15
@kschoche kschoche self-assigned this May 27, 2022
@kschoche kschoche requested review from ndhanushkodi and ishustava and removed request for a team May 27, 2022 04:15
ndhanushkodi
ndhanushkodi approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@ndhanushkodi ndhanushkodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@kschoche kschoche merged commit bd700ff into main May 27, 2022
@kschoche kschoche deleted the add_agent_annotations_to_apigw branch May 27, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndhanushkodi ndhanushkodi ndhanushkodi approved these changes

@jmurret jmurret jmurret approved these changes

@nickethier nickethier Awaiting requested review from nickethier

@ishustava ishustava Awaiting requested review from ishustava

Assignees

@kschoche kschoche

Labels
theme/api-gateway Related to Consul API Gateway vault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass Vault agent annotations to Consul API Gateway controller
3 participants
@kschoche @jmurret @ndhanushkodi