Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update api module and exported services validation #1248

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Update api module and exported services validation #1248

merged 1 commit into from
Jun 3, 2022

Conversation

ndhanushkodi
Copy link
Contributor

@ndhanushkodi ndhanushkodi commented May 31, 2022 •
edited
Loading

Changes proposed in this PR:

  • Update api module and corresponding function signature changes for peering API endpoints
  • Update exported services CRD validation: it is no longer an ENT-only CRD, so the validation behavior now accounts for each of those cases, and won't reject the CR in OSS.
    • Only when namespaces are enabled, you can specify the namespace of an exported service
    • Enforces that the name of the CR is "default" in OSS or in the default partition, or equal to the partition name if partitions are enabled.

How I've tested this PR:

  • unit tests

How I expect reviewers to test this PR:

  • 👀

Checklist:

  • Tests added
  • [-] CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

thisisnotashwin
thisisnotashwin approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOICE!

@ndhanushkodi ndhanushkodi changed the title Update api module and corresponding function signature changes Update api module and exported services validation Jun 2, 2022
@ndhanushkodi ndhanushkodi requested review from a team, ishustava and t-eckert and removed request for a team June 2, 2022 23:30
@ndhanushkodi
Copy link
Contributor Author

This is ready for another round of review

thisisnotashwin
thisisnotashwin approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on the tests and also extending consulNamespace() to return "" when namespaces are disabled!! 🥇

@ndhanushkodi ndhanushkodi merged commit a12db71 into peering Jun 3, 2022
@ndhanushkodi ndhanushkodi deleted the bump-api-module branch June 3, 2022 21:01
ndhanushkodi added a commit that referenced this pull request Jun 13, 2022
@ndhanushkodi
update api module, update exported services validation (#1248)
95c25c7
ndhanushkodi added a commit that referenced this pull request Jun 13, 2022
@ndhanushkodi
update api module, update exported services validation (#1248)
fa1936c
ndhanushkodi added a commit that referenced this pull request Jun 13, 2022
@ndhanushkodi
update api module, update exported services validation (#1248)
1193b83
ndhanushkodi added a commit that referenced this pull request Jun 15, 2022
@ndhanushkodi
update api module, update exported services validation (#1248)
dae0fd3
thisisnotashwin pushed a commit that referenced this pull request Jun 16, 2022
@ndhanushkodi @thisisnotashwin
update api module, update exported services validation (#1248)
3e848cf
thisisnotashwin pushed a commit that referenced this pull request Jun 16, 2022
@ndhanushkodi @thisisnotashwin
update api module, update exported services validation (#1248)
a28d4eb
thisisnotashwin pushed a commit that referenced this pull request Jun 20, 2022
@ndhanushkodi @thisisnotashwin
update api module, update exported services validation (#1248)
58feac8
thisisnotashwin pushed a commit that referenced this pull request Jun 20, 2022
@ndhanushkodi @thisisnotashwin
update api module, update exported services validation (#1248)
2d2ab95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisnotashwin thisisnotashwin thisisnotashwin approved these changes

@ishustava ishustava Awaiting requested review from ishustava

@t-eckert t-eckert Awaiting requested review from t-eckert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndhanushkodi @thisisnotashwin