Add helm value to enable cluster peering #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charts/consul/values.yaml
Outdated
| @@ -29,6 +29,13 @@ global: | |||
| # Consul into Kubernetes will have, e.g. `service-name.service.consul`. | |||
| domain: consul | |||
|
|
|||
| # Configures the Cluster Peering feature. | |||
There was a problem hiding this comment.
Should we mark this with [TECH PREVIEW] or something?
There was a problem hiding this comment.
i added [Experimental] for this and the CRD fields
There was a problem hiding this comment.
would [Tech Preview] make more sense? I thought it might be a more internal word?
lkysow
reviewed
Jun 13, 2022
Comment on lines
+34
to
+37
| # If true, the Helm chart will enable Cluster Peering for the cluster. This will enable peering controllers and | ||
| # allow use of the PeeringAcceptor and PeeringDialer CRDs to establish peerings for service mesh. | ||
| # @type boolean | ||
| enabled: false |
There was a problem hiding this comment.
Should say which version is required
There was a problem hiding this comment.
added this for the peering block, thanks!
ndhanushkodi
force-pushed
the
peering-helm-value
branch
from
0315efe to
6c8c7ee
Compare
… is not set when peering is
ishustava
approved these changes
Jun 13, 2022
ndhanushkodi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
unit tests
How I expect reviewers to test this PR:
👀
Checklist: