Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove check for clients in status command #1573

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Remove check for clients in status command #1573

merged 1 commit into from
Oct 4, 2022

Conversation

t-eckert
Copy link
Contributor

Changes proposed in this PR:

  • Remove the check for Consul clients in the consul-k8s status command. Clients don't exist in agentless (RIP).

How I've tested this PR:

  • Unit tests
  • Manual install -> status check -> uninstall

How I expect reviewers to test this PR:

  • Unit tests
  • Manual install -> status check -> uninstall
  • 👀

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@t-eckert t-eckert requested review from a team, ishustava and wilkermichael and removed request for a team September 30, 2022 18:16
@t-eckert t-eckert force-pushed the cli/remove-client-check-agentless branch from ef173f3 to 9f26fb6 Compare October 3, 2022 16:06
@t-eckert t-eckert requested a review from ishustava October 3, 2022 17:01
@t-eckert t-eckert merged commit e6f80da into main Oct 4, 2022
@t-eckert t-eckert deleted the cli/remove-client-check-agentless branch October 4, 2022 20:14
jmurret pushed a commit that referenced this pull request Oct 6, 2022
@jmurret
Remove check for clients in status command (#1573)
dde6ec5
@natitomattis natitomattis mentioned this pull request Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilkermichael wilkermichael wilkermichael approved these changes

@ishustava ishustava ishustava approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@t-eckert @ishustava @wilkermichael