Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tolerations and nodeSelector to Server ACL init jobs and nodeSelector to Webhook cert manager #1581

Merged
merged 10 commits into from
Oct 18, 2022
Merged

Add tolerations and nodeSelector to Server ACL init jobs and nodeSelector to Webhook cert manager #1581

merged 10 commits into from
Oct 18, 2022

Conversation

t-eckert
Copy link
Contributor

@t-eckert t-eckert commented Oct 3, 2022

This solution is in response to an ask from a customer who wants to set nodeSelector for all Pods in their cluster. This adds that capability to server-acl-init jobs and webhook-cert-manager.

Changes proposed in this PR:

  • Add a Helm stanza, global.acls.job for configuring server-acl-init and server-acl-init-cleanup jobs.
  • Add the Helm value global.acls.job.tolerations for setting tolerations on server-acl-init and server-acl-init-cleanup jobs.
  • Add the Helm value global.acls.job.nodeSelector for setting the nodeSelector on server-acl-init and server-acl-init-cleanup jobs.
  • Add the Helm value webhookCertManager.nodeSelector for setting the nodeSelector on webhook-cert-manager-deployment.
  • Add BATS tests for all of the above changes.

How I've tested this PR:

  • I deployed the following Helm values into an AKS account to ensure that Consul runs normally when server-acl-init and webhook-cert-manager are deployed on a particular node. There is no anticipated reason why they shouldn't.

How I expect reviewers to test this PR:

  • 👀
  • Run a Helm chart that sets nodeSelector.

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@t-eckert t-eckert requested review from ishustava and jmurret October 3, 2022 21:31
t-eckert
t-eckert commented Oct 3, 2022
View reviewed changes
charts/consul/values.yaml Outdated Show resolved Hide resolved
ishustava
ishustava reviewed Oct 14, 2022
View reviewed changes
Copy link
Contributor

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment about helm values.

charts/consul/values.yaml Outdated Show resolved Hide resolved
@t-eckert t-eckert requested a review from ishustava October 14, 2022 19:14
ishustava
ishustava reviewed Oct 14, 2022
View reviewed changes
Copy link
Contributor

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! A few more comments. I didn't notice these in my first review

charts/consul/test/unit/server-acl-init-cleanup-job.bats Outdated Show resolved Hide resolved
charts/consul/test/unit/server-acl-init-cleanup-job.bats Outdated Show resolved Hide resolved
charts/consul/test/unit/server-acl-init-cleanup-job.bats Outdated Show resolved Hide resolved
charts/consul/templates/server-acl-init-job.yaml Outdated Show resolved Hide resolved
charts/consul/values.yaml Outdated Show resolved Hide resolved
charts/consul/values.yaml Outdated Show resolved Hide resolved
charts/consul/values.yaml Outdated Show resolved Hide resolved
Thomas Eckert and others added 2 commits October 14, 2022 18:32
@ishustava
Apply suggestions from code review
19012ef 
Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
Fix indent and files targeted by bats
24e616c
@t-eckert t-eckert requested a review from ishustava October 14, 2022 22:37
jmurret
jmurret approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@jmurret jmurret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 :shipit:

@t-eckert t-eckert merged commit b7f4995 into main Oct 18, 2022
@t-eckert t-eckert deleted the add-nodeSelector branch October 18, 2022 17:47
Merged
2 tasks
@t-eckert t-eckert mentioned this pull request Oct 18, 2022
Merged
2 tasks
Closed
2 tasks
@t-eckert t-eckert mentioned this pull request Oct 18, 2022
Merged
2 tasks
@natitomattis natitomattis mentioned this pull request Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishustava ishustava ishustava approved these changes

@jmurret jmurret jmurret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@t-eckert @jmurret @ishustava @david-yu