consul-k8s CLI - hcp self-managed clusters - fix the required environment variables that should just default to production settings #1593
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
The following envvars can be passed to the consul-k8s CLI so they get used in the cluster creation and bootstrapping:
HCP_CLIENT_ID (required)
HCP_CLIENT_SECRET (required)
HCP_AUTH_URL
HCP_SCADA_ADDRESS
HCP_API_HOST
All of the ones that are not marked as required were exposed by the hcp-sdk so that we could test in other environments besides production. When they are not provided, hcp sdk will default them to prod settings, and they are truly optional.
There is currently a bug in consul-k8s CLI where when these are not provided to consul-k8s CLI, they still get set on the server pod as empty strings. The hcp sdk then recognizes that they are there and says they cannot be empty strings.
How I've tested this PR:
How I expect reviewers to test this PR:
👀
Checklist: