Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to go1.19.2 #1633

Merged
merged 4 commits into from
Oct 20, 2022
Merged

Upgrade to go1.19.2 #1633

merged 4 commits into from
Oct 20, 2022

Conversation

analogue
Copy link
Collaborator

@analogue analogue commented Oct 19, 2022 •
edited
Loading

Context: NET-240

Changes proposed in this PR:

  • Upgrade to go 1.19.2
  • Upgrade to gotestsum 1.8.2

How I've tested this PR:

  • unit and acceptance tests are ✅

How I expect reviewers to test this PR:
👀

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@analogue analogue requested review from a team, ishustava and t-eckert and removed request for a team October 19, 2022 15:42
@analogue analogue marked this pull request as ready for review October 19, 2022 15:44
jmurret
jmurret approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@jmurret jmurret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Approving but left one suggestion for using the anchor you created.

.circleci/config.yml Outdated Show resolved Hide resolved
@analogue @jmurret
Missed an anchor!
6432651 
Co-authored-by: John Murret <john.murret@hashicorp.com>
jmurret
jmurret requested changes Oct 19, 2022
View reviewed changes
Copy link
Member

@jmurret jmurret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a changelog entry and please leave that reminder from the PR template in your PR? The changelog should be similar to this: https://github.com/hashicorp/consul-k8s/pull/1292/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR2-R7

@jmurret
Copy link
Member

jmurret commented Oct 19, 2022 •
edited
Loading

also, this is missing the following files, which means you need to run go mod tidy in each of these directories after you modify go.mod.

  • acceptance/go.sum
  • cli/go.sum
  • control-plane/go.sum

For reference, I am auditing your PR against the two PRs linked in the JIRA ticket. I think this and the changelog entry are the missing items.

@analogue
Copy link
Collaborator Author

also, this is missing the following files, which means you need to run go mod tidy in each of these directories after you modify go.mod.

* acceptance/go.sum

* cli/go.sum

* control-plane/go.sum

For reference, I am auditing your PR against the two PRs linked in the JIRA ticket. I think this and the changelog entry are the missing items.

I re-ran go mod tidy on those files, but it didn't yield any changes.

@analogue analogue requested a review from jmurret October 19, 2022 18:35
jmurret
jmurret approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@jmurret jmurret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ❤️ :shipit:

t-eckert
t-eckert approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@t-eckert t-eckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@analogue analogue merged commit 7f6620d into main Oct 20, 2022
@analogue analogue deleted the sp/bump-go-1.19 branch October 20, 2022 21:27
t-eckert pushed a commit that referenced this pull request Oct 31, 2022
@analogue
Upgrade to go1.19.2 (#1633)
73e9377
@natitomattis natitomattis mentioned this pull request Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-eckert t-eckert t-eckert approved these changes

@jmurret jmurret jmurret approved these changes

@ishustava ishustava Awaiting requested review from ishustava

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@analogue @jmurret @t-eckert