Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sync partitions acceptance test #1670

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Fix sync partitions acceptance test #1670

merged 1 commit into from
Nov 4, 2022

Conversation

ishustava
Copy link
Contributor

@ishustava ishustava commented Nov 2, 2022 •
edited
Loading

Changes proposed in this PR:

  • Fix service name for the servers in the partitions sync test

How I've tested this PR:
acceptance tests: they all failed because of the server-acl-init changes, but partitions sync non-secure test passed!

How I expect reviewers to test this PR:
👀

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@ishustava ishustava marked this pull request as ready for review November 4, 2022 20:52
thisisnotashwin
thisisnotashwin approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooh..nice find..sneaky hardcodes!!

@ishustava ishustava force-pushed the ishustava/fix-partitions-sync-test branch from 9c2f964 to d6f5ad7 Compare November 4, 2022 20:54
@ishustava ishustava requested review from a team, analogue and kschoche and removed request for a team November 4, 2022 20:54
kschoche
kschoche approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@kschoche kschoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@ishustava ishustava merged commit cbdbc95 into main Nov 4, 2022
@ishustava ishustava deleted the ishustava/fix-partitions-sync-test branch November 4, 2022 21:51
@natitomattis natitomattis mentioned this pull request Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kschoche kschoche kschoche approved these changes

@thisisnotashwin thisisnotashwin thisisnotashwin approved these changes

@analogue analogue Awaiting requested review from analogue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ishustava @kschoche @thisisnotashwin