Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to apply additional labels to the connect inject pods #1678

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Allow to apply additional labels to the connect inject pods #1678

merged 1 commit into from
Nov 11, 2022

Conversation

ilpianista
Copy link
Contributor

@ilpianista ilpianista commented Nov 4, 2022 •
edited by curtbushko
Loading

Changes proposed in this PR:

  • Allow to apply additional labels to the connect inject pods

How I've tested this PR:
We run this in our production.

How I expect reviewers to test this PR:
I've added a unit tests.

Checklist:

@david-yu
Copy link
Contributor

david-yu commented Nov 4, 2022

Thank you, this looks great we will take a look!

thisisnotashwin
thisisnotashwin approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the contribution!!

@thisisnotashwin thisisnotashwin requested review from a team, curtbushko and ishustava and removed request for a team November 9, 2022 20:03
curtbushko
curtbushko approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for your contribution! It is very much appreciated!

@thisisnotashwin thisisnotashwin merged commit d7cbe44 into hashicorp:main Nov 11, 2022
@david-yu david-yu mentioned this pull request Nov 12, 2022
Closed
2 tasks
@ilpianista ilpianista deleted the feature/consul-inject-extraLabels branch November 14, 2022 11:12
@david-yu david-yu mentioned this pull request Dec 7, 2022
Merged
2 tasks
@natitomattis natitomattis mentioned this pull request Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisnotashwin thisisnotashwin thisisnotashwin approved these changes

@curtbushko curtbushko curtbushko approved these changes

@ishustava ishustava Awaiting requested review from ishustava

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ilpianista @david-yu @curtbushko @thisisnotashwin