Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

peering: fix acl issue #1685

Merged
merged 3 commits into from
Nov 8, 2022
Merged

peering: fix acl issue #1685

merged 3 commits into from
Nov 8, 2022

Conversation

ndhanushkodi
Copy link
Contributor

@ndhanushkodi ndhanushkodi commented Nov 8, 2022 •
edited
Loading

Changes proposed in this PR:

  • Add peering:read permissions that are compatible with OSS and ENT Consul images. The comment next to the rule explains this further.
  • Fix this log line that shows up in acceptance tests by adding peering permissions to the mesh gateway token. This makes the peering connection actually go through both mesh gateways (as opposed to just the remote mesh gateway)agent.proxycfg: Failed to handle update from watch: kind=mesh-gateway proxy=test-dyqcwc-consul-mesh-gateway-556fd7855b-fzjq7 service_id=test-dyqcwc-consul-mesh-gateway-556fd7855b-fzjq7 id=peer-servers error="error filling agent cache: Permission denied: token with AccessorID 'c2c7bd05-0e5d-45b2-f2c1-36455c4977e5' lacks permission 'peering:read'"

How I've tested this PR:

How I expect reviewers to test this PR:

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@ndhanushkodi ndhanushkodi changed the base branch from main to nd/peering-improvements November 8, 2022 19:10
@ndhanushkodi ndhanushkodi force-pushed the nd/peering-improvements branch from 796a0c7 to a5d4284 Compare November 8, 2022 19:16
Base automatically changed from nd/peering-improvements to main November 8, 2022 19:25
@ndhanushkodi
Copy link
Contributor Author

The metrics test failure is unrelated, so I'm marking ready for review, while checking out what's up for that test

@ndhanushkodi ndhanushkodi marked this pull request as ready for review November 8, 2022 20:51
@ndhanushkodi ndhanushkodi requested review from a team, thisisnotashwin and wilkermichael and removed request for a team November 8, 2022 20:51
wilkermichael
wilkermichael approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@wilkermichael wilkermichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me Nitya!

Great work!

@ndhanushkodi ndhanushkodi merged commit 2edd635 into main Nov 8, 2022
@ndhanushkodi ndhanushkodi deleted the nd/peering-acl branch November 8, 2022 22:41
@natitomattis natitomattis mentioned this pull request Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilkermichael wilkermichael wilkermichael approved these changes

@thisisnotashwin thisisnotashwin thisisnotashwin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndhanushkodi @thisisnotashwin @wilkermichael