helm: default dns values inherit from connectInject.transparentProxy.defaultEnabled #1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndhanushkodi
changed the title
ndhanushkodi
requested review from
a team,
analogue and
t-eckert
and removed request for
a team
|
The failing acceptance tests are due to an agentless change for distroless image, so this is ready for review! |
t-eckert
reviewed
Nov 9, 2022
CHANGELOG.md
Outdated
| @@ -9,6 +9,9 @@ BREAKING_CHANGES: | |||
| * `client.snaphostAgent.replicas` | |||
| * `client.snaphostAgent.serviceAccount` | |||
| * Remove `global.secretsBackend.vault.consulSnapshotAgentRole` value. You should now use the `global.secretsBackend.vault.consulServerRole` for access to any Vault secrets. | |||
| * Change`dns.enabled` and `dns.enableRedirection` to default to the value of `connectInject.transparentProxy.defaultEnabled`. | |||
| Previously, `dns.enabled` defaulted to the value of `global.enabled` and `dns.enableRedirection` defaulted to the | |||
| value ot `false`. [[GH-1688](https://github.com/hashicorp/consul-k8s/pull/1688)] | |||
There was a problem hiding this comment.
Suggested change
| value ot `false`. [[GH-1688](https://github.com/hashicorp/consul-k8s/pull/1688)] | |
| value to `false`. [[GH-1688](https://github.com/hashicorp/consul-k8s/pull/1688)] |
analogue
approved these changes
Nov 9, 2022
ndhanushkodi
force-pushed
the
nd/default-dns
branch
from
e504ab4
to
9ec955e
Compare
…automatically be enabled/disabled by tproxy settings
… should automatically be enabled/disabled by tproxy settings" This reverts commit 237cbdc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
dns.enableddefaulted to inherit fromglobal.enabled, anddns.enableRedirectiondefaulted tofalse. Now, both of these dns values will default to inherit fromconnectInject.transparentProxy.defaultEnabled.How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: