Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remaining helm values changes and cleanup #1698

Merged
merged 4 commits into from
Nov 14, 2022
Merged

Remaining helm values changes and cleanup #1698

merged 4 commits into from
Nov 14, 2022

Conversation

curtbushko
Copy link
Contributor

@curtbushko curtbushko commented Nov 10, 2022 •
edited
Loading

Changes proposed in this PR:

  • Cleanup any places where we missed some helm values from the agentless changes.
  • This is most easily reviewed by commit.
  • I am going to do a CHANGELOG pass also for all the PRs this release (probably Monday)

How I've tested this PR:

  • ran unit, bats & acceptance tests

How I expect reviewers to test this PR:

👀

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@curtbushko curtbushko marked this pull request as ready for review November 10, 2022 20:38
ishustava
ishustava approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!! Thank you so much!

@curtbushko curtbushko force-pushed the curtbushko/agentless-helm-values branch from 3227a47 to a2567a7 Compare November 14, 2022 14:59
@curtbushko curtbushko merged commit 8920843 into main Nov 14, 2022
@curtbushko curtbushko deleted the curtbushko/agentless-helm-values branch November 14, 2022 15:12
@natitomattis natitomattis mentioned this pull request Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisnotashwin thisisnotashwin thisisnotashwin approved these changes

@ishustava ishustava ishustava approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@curtbushko @ishustava @thisisnotashwin