Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Set default path for prometheus scrape path to /metrics #1709

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Fix: Set default path for prometheus scrape path to /metrics #1709

merged 1 commit into from
Nov 15, 2022

Conversation

curtbushko
Copy link
Contributor

@curtbushko curtbushko commented Nov 14, 2022 •
edited
Loading

Changes proposed in this PR:

  • Pass a default /metrics path to the consul-dataplane use the -telemetry-prom-scrape-path flag.
  • Added a little test case that simulates setting a custom path as a flag.
  • No CHANGELOG required as this was the default behaviour in the past.

How I've tested this PR:

  • unit & acceptance tests

How I expect reviewers to test this PR:
👀

Checklist:

  • Tests added
  • CHANGELOG entry added in CHANGELOG updates for 1.0 #1727

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@curtbushko curtbushko marked this pull request as ready for review November 14, 2022 19:11
@curtbushko curtbushko changed the title Set default /metrics path for prometheus scrape path Fix: Set default path for prometheus scrape path to /metrics Nov 14, 2022
thisisnotashwin
thisisnotashwin approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@curtbushko curtbushko merged commit 503e4c5 into main Nov 15, 2022
@curtbushko curtbushko deleted the curtbushko/default-telemetry-prom-scrape-path branch November 15, 2022 20:23
@natitomattis natitomattis mentioned this pull request Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisnotashwin thisisnotashwin thisisnotashwin approved these changes

@ishustava ishustava ishustava approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@curtbushko @ishustava @thisisnotashwin