Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting CONSUL_TLS_SERVER_NAME when global.gloud.enabled is set. #1717

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Setting CONSUL_TLS_SERVER_NAME when global.gloud.enabled is set. #1717

merged 1 commit into from
Nov 17, 2022

Conversation

jmurret
Copy link
Member

@jmurret jmurret commented Nov 15, 2022

Changes proposed in this PR:

  • Setting CONSUL_TLS_SERVER_NAME when global.gloud.enabled is set.

How I've tested this PR:

  • manually installed the cloud preset to test this works.
  • unit tests
    How I expect reviewers to test this PR:
    👀

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

curtbushko
curtbushko approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@thisisnotashwin thisisnotashwin merged commit acc4797 into main Nov 17, 2022
@thisisnotashwin thisisnotashwin deleted the jm/fix-gnm-server-acl-init branch November 17, 2022 15:39
@natitomattis natitomattis mentioned this pull request Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curtbushko curtbushko curtbushko approved these changes

@ndhanushkodi ndhanushkodi ndhanushkodi approved these changes

@thisisnotashwin thisisnotashwin thisisnotashwin approved these changes

@ishustava ishustava Awaiting requested review from ishustava

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmurret @curtbushko @ndhanushkodi @thisisnotashwin