Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues found in the nightly tests #1735

Merged
merged 10 commits into from
Nov 17, 2022
Merged

Fix issues found in the nightly tests #1735

merged 10 commits into from
Nov 17, 2022

Conversation

ishustava
Copy link
Contributor

@ishustava ishustava commented Nov 17, 2022 •
edited
Loading

Changes proposed in this PR:

  • use ubuntu based image for static-client in acceptance tests because alpine images are known to be flakey with DNS on kubernetes: https://stackoverflow.com/questions/65181012/does-alpine-have-known-dns-issue-within-kubernetes
  • Fix ACL permissions for the connect injector to make wan federations tests pass. Previously, injector only needed the global auth method when namespaces are enabled. Now that we've joined it with the controller, it needs global auth method in the secondary all the time.
  • Fix debug info from envoy (previously we were assuming there's consul-sidecar). This change also adds debugging info to all pods that use envoy.

How I've tested this PR:
acceptance and unit tests

How I expect reviewers to test this PR:
👀

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@ishustava ishustava marked this pull request as ready for review November 17, 2022 18:33
curtbushko
curtbushko approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 out of 4 therapists approve!

@ishustava ishustava merged commit 0b1cc2b into main Nov 17, 2022
@ishustava ishustava deleted the nd/cloud-tests branch November 17, 2022 19:19
@natitomattis natitomattis mentioned this pull request Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curtbushko curtbushko curtbushko approved these changes

@thisisnotashwin thisisnotashwin thisisnotashwin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ishustava @curtbushko @thisisnotashwin @ndhanushkodi