Backport of Add fix for api-gateway when using system-wide trusted CAs for external servers into release/1.0.x #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-ecosystem
force-pushed
the
backport/as/system-ca-fix/loosely-topical-gibbon
branch
from
a456240
to
a66626a
Compare
Add fix for api-gateway when using system-wide trusted CAs for external servers
andrewstucki
approved these changes
Nov 18, 2022
andrewstucki
deleted the
backport/as/system-ca-fix/loosely-topical-gibbon
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #1743 to be assessed for backporting due to the inclusion of the label backport/1.0.x.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
Changes proposed in this PR:
This adds some logic that was forgotten around leveraging
externalServers.useSystemRoots. Without it, attempting to use something like HCP as an external server without agents causes the gateway controller to fail validating the Consul server connection since it's using the wrong certificate authority.How I've tested this PR:
Validated against HCP with the api-gateway changes in hashicorp/consul-api-gateway#459
Checklist:
Overview of commits