Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for 1.0.1 release #1752

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Prepare for 1.0.1 release #1752

merged 1 commit into from
Nov 21, 2022

Conversation

curtbushko
Copy link
Contributor

@curtbushko curtbushko commented Nov 21, 2022 •
edited
Loading

Changes proposed in this PR:

  • The last PR went wonky on me during the rebase. This is much nicer.
  • This branch is never in dev mode...

How I've tested this PR:

How I expect reviewers to test this PR:

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

kschoche
kschoche approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@kschoche kschoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🚒

@curtbushko curtbushko marked this pull request as ready for review November 21, 2022 21:43
@curtbushko curtbushko mentioned this pull request Nov 21, 2022
Closed
2 tasks
@wilkermichael
Copy link
Contributor

Yeah, I think it makes sense going forward to not backport the pre-release, let's just PR directly onto the release branch like above. Good call doing this again!

@curtbushko curtbushko merged commit e230ba8 into release/1.0.x Nov 21, 2022
@curtbushko curtbushko deleted the pre-release/1.0.1 branch November 21, 2022 22:50
@natitomattis natitomattis mentioned this pull request Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndhanushkodi ndhanushkodi ndhanushkodi approved these changes

@kschoche kschoche kschoche approved these changes

@wilkermichael wilkermichael wilkermichael approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@curtbushko @wilkermichael @ndhanushkodi @kschoche