Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extra envoy args to be passed in #177

Conversation

kevinjqiu
Copy link
Contributor

Allow extra envoy CLI option to be passed in. One such use case is when I want to increase/decrease the log level of the envoy sidecar process, I need to run envoy with --log-level xyz or --component-log-level xyz:level

@hashicorp-cla
Copy link

hashicorp-cla commented Dec 11, 2019

CLA assistant check
All committers have signed the CLA.

@lkysow lkysow added area/connect Related to Connect service mesh, e.g. injection type/enhancement New feature or request labels Dec 11, 2019
@kevinjqiu
Copy link
Contributor Author

I don't think the test failure is due to my change:

=== Failed
=== FAIL: helper/cert TestGenSource_expiry (600.10s)
=== PAUSE TestGenSource_expiry
=== CONT  TestGenSource_expiry
--- PASS: TestGenSource_expiry (2.20s)
    source_gen_test.go:116: leaf.pem: OK
        
    source_gen_test.go:116: leaf.pem: OK
        
panic: test timed out after 10m0s
...

@lkysow
Copy link
Member

lkysow commented Dec 19, 2019

Hey Kevin, thanks for the PR. Would this also work as an annotation on the Pod?

@ndhanushkodi ndhanushkodi merged commit a5251b7 into hashicorp:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connect Related to Connect service mesh, e.g. injection type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants