Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIRA: Use env when creating with custom fields #1786

Merged
merged 7 commits into from
Dec 13, 2022
Merged

Conversation

david-yu
Copy link
Contributor

Changes proposed in this PR:

  • Adding this in towards end of create JIRA action

    env:
        JIRA_BASE_URL: ${{ secrets.JIRA_BASE_URL }}
        JIRA_USER_EMAIL: ${{ secrets.JIRA_USER_EMAIL }}
        JIRA_API_TOKEN: ${{ secrets.JIRA_API_TOKEN }}
    -
    

How I've tested this PR:

How I expect reviewers to test this PR:

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

Use auth
@@ -34,7 +34,7 @@ jobs:

- name: Create ticket
if: ( github.event.action == 'opened' && steps.set-ticket-type.outputs.type != 'Task' ) || ( github.event.action == 'opened' && steps.set-ticket-type.outputs.type == 'Task' )
uses: tomhjp/gh-action-jira-create@v0.1.3
uses: tomhjp/gh-action-jira-create@v0.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going back to 2.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I don't think the 0.1.3 made any difference, the issue was Auth was not working when using the action when custom fields were used in JIRA

David Yu added 3 commits December 13, 2022 12:11
add check to make sure PRs filed by team members don't create JIRA issues
David Yu added 3 commits December 13, 2022 12:16
going to login v2.0.0 just in case to match hcdiag
@@ -15,7 +15,7 @@ jobs:
name: Jira sync
steps:
- name: Login
uses: atlassian/gajira-login@v3
uses: atlassian/gajira-login@v2.0.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be some kind auth issue so going back to v2.0.0 just in case

@david-yu david-yu merged commit e4fde53 into main Dec 13, 2022
@david-yu david-yu deleted the dyu/jira-create-test branch December 13, 2022 20:33
david-yu pushed a commit that referenced this pull request Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants