Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick go changelog 1 0 #1960

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Cherry pick go changelog 1 0 #1960

merged 1 commit into from
Feb 28, 2023

Conversation

wilkermichael
Copy link
Contributor

Changes proposed in this PR:

  • manual cherry pick since cherry pick failed

How I've tested this PR:

How I expect reviewers to test this PR:

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@wilkermichael
update prepare release to update the changelog
cd5e339 
- Prepare release now requires an additional LAST_RELEASE_GIT_TAG environment variable required by go-changelog
- removed adding the unreleased tag to the Changelog as we will no longer be doing that. All changelog entries will be added at the time of release by the go-changelog tool
@wilkermichael wilkermichael requested review from a team, erichaberkorn and curtbushko and removed request for a team February 28, 2023 19:46
@wilkermichael wilkermichael changed the base branch from main to release/1.0.x February 28, 2023 19:46
@wilkermichael wilkermichael added pr/no-changelog PR does not need a corresponding .changelog entry and removed pr/no-changelog PR does not need a corresponding .changelog entry labels Feb 28, 2023
@wilkermichael wilkermichael merged commit b38b1a3 into release/1.0.x Feb 28, 2023
@wilkermichael wilkermichael deleted the cherry-pick-go-changelog-1-0 branch February 28, 2023 21:15
@natitomattis natitomattis mentioned this pull request Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curtbushko curtbushko curtbushko approved these changes

@thisisnotashwin thisisnotashwin thisisnotashwin approved these changes

@erichaberkorn erichaberkorn Awaiting requested review from erichaberkorn erichaberkorn was automatically assigned from hashicorp/consul-core-service-mesh

Assignees
No one assigned
Labels
pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wilkermichael @curtbushko @thisisnotashwin