Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added more retries for tests #2006

Merged
merged 1 commit into from
Mar 13, 2023
Merged

added more retries for tests #2006

merged 1 commit into from
Mar 13, 2023

Conversation

wilkermichael
Copy link
Contributor

Changes proposed in this PR:

  • Added some additional retries to tests around port forwarding and calls to the kubernetes client

How I've tested this PR:

  • Ran these with my manually triggered pipelines the other night, seemed to help reduce flakiness... but still flaky

How I expect reviewers to test this PR:
👀

Checklist:

  • [n/a] Tests added
  • [n/a] CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@wilkermichael wilkermichael added backport/0.49.x backport/1.1.x Backport to release/1.1.x branch pr/no-changelog PR does not need a corresponding .changelog entry labels Mar 10, 2023
@wilkermichael wilkermichael merged commit 6fbb20f into main Mar 13, 2023
@wilkermichael wilkermichael deleted the mw/add-test-retries branch March 13, 2023 17:03
This was referenced Mar 13, 2023
Closed
Merged
absolutelightning pushed a commit that referenced this pull request Aug 4, 2023
@wilkermichael @absolutelightning
added more retries for tests (#2006)
3e2f77c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisnotashwin thisisnotashwin thisisnotashwin approved these changes

@ndhanushkodi ndhanushkodi Awaiting requested review from ndhanushkodi

Assignees
No one assigned
Labels
backport/1.1.x Backport to release/1.1.x branch pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wilkermichael @thisisnotashwin