Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[COMPLIANCE] add copyright headers to files #2016

Merged
merged 4 commits into from
Mar 28, 2023
Merged

[COMPLIANCE] add copyright headers to files #2016

merged 4 commits into from
Mar 28, 2023

Conversation

roncodingenthusiast
Copy link
Contributor

Changes proposed in this PR:

  • adding copyright headers to all files for compliance purposes
  • add copywrite config file to allow dependabot style PRs for any file missing headers in the future

How I expect reviewers to test this PR:

  • 👀

@roncodingenthusiast roncodingenthusiast requested review from dlaguerta, a team, skpratt and kisunji and removed request for a team March 15, 2023 12:43
@roncodingenthusiast roncodingenthusiast added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport signals that a PR will not contain a backport label labels Mar 15, 2023
@david-yu
Copy link
Contributor

Btw it does look like there are some actual failures in unit tests that need to be fixed before merging.

eikenb
eikenb reviewed Mar 22, 2023
View reviewed changes
cli/helm/chart_test.go
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need copyright headers on generated, test/mock files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably not critical to have them, I am removing some of them

@roncodingenthusiast roncodingenthusiast merged commit 54ec4b6 into main Mar 28, 2023
@roncodingenthusiast roncodingenthusiast deleted the copyright-config-file branch March 28, 2023 15:04
@roncodingenthusiast roncodingenthusiast mentioned this pull request Mar 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eikenb eikenb eikenb left review comments

@skpratt skpratt skpratt approved these changes

@dlaguerta dlaguerta dlaguerta approved these changes

@kisunji kisunji kisunji approved these changes

Assignees
No one assigned
Labels
pr/no-backport signals that a PR will not contain a backport label pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@roncodingenthusiast @david-yu @eikenb @skpratt @dlaguerta @kisunji