Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the indentation of the copyAnnotations example #2037

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Fix the indentation of the copyAnnotations example #2037

merged 1 commit into from
Apr 5, 2023

Conversation

t-eckert
Copy link
Contributor

@t-eckert t-eckert commented Apr 4, 2023

Changes proposed in this PR:

  • Fixes the docs example where copyAnnotations.service.annotation has the wrong indentation. This caused some confusion for a customer recently. Just needs an extra two spaces.

@t-eckert t-eckert added pr/no-changelog PR does not need a corresponding .changelog entry backport/0.49.x backport/1.1.x Backport to release/1.1.x branch labels Apr 4, 2023
@t-eckert t-eckert mentioned this pull request Apr 4, 2023
Merged
2 tasks
nathancoleman
nathancoleman approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@nathancoleman nathancoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this is what actually works when installing w/ API Gateway

david-yu
david-yu approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@david-yu david-yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Joining in on the party

@nathancoleman nathancoleman merged commit 2cff14e into main Apr 5, 2023
@nathancoleman nathancoleman deleted the fix-indent-of-copyAnnotations branch April 5, 2023 03:34
This was referenced Apr 5, 2023
Merged
Merged
Merged
absolutelightning pushed a commit that referenced this pull request Aug 4, 2023
@absolutelightning
Fix the indentation of the copyAnnotations example (#2037)
ff2a41d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-yu david-yu david-yu approved these changes

@lkysow lkysow lkysow approved these changes

@nathancoleman nathancoleman nathancoleman approved these changes

Assignees
No one assigned
Labels
backport/1.1.x Backport to release/1.1.x branch pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@t-eckert @david-yu @lkysow @nathancoleman