Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Spatel/net 1646 add max ejection percent and base ejection time into release/1.0.x #2106

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #2064 to be assessed for backporting due to the inclusion of the label backport/1.0.x.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

merge conflict error: unable to process merge commit: "669d94cf415c22c8e6956048a675b74965fd9f8a", automatic backport requires rebase workflow

The below text is copied from the body of the original PR.


Changes proposed in this PR:
add max ejection percent and base ejection time to passiveHealthCheck

How I've tested this PR: local test and with wan federation setup

How I expect reviewers to test this PR:

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/spatel/NET-1646-add-max-ejection-percent-and-base-ejection-time/eagerly-stunning-spaniel branch from d9bae3c to ee00f9c Compare May 4, 2023 21:33
@malizz malizz marked this pull request as ready for review May 5, 2023 21:16
@malizz malizz force-pushed the backport/spatel/NET-1646-add-max-ejection-percent-and-base-ejection-time/eagerly-stunning-spaniel branch from 460d858 to 2a3c199 Compare May 9, 2023 19:28
@malizz malizz merged commit 2bfc943 into release/1.0.x May 9, 2023
@malizz malizz deleted the backport/spatel/NET-1646-add-max-ejection-percent-and-base-ejection-time/eagerly-stunning-spaniel branch May 9, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants