Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Gateway Service Deregistration #2388

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Fix Gateway Service Deregistration #2388

merged 1 commit into from
Jun 15, 2023

Conversation

t-eckert
Copy link
Contributor

@t-eckert t-eckert commented Jun 15, 2023 •
edited by nathancoleman
Loading

This PR merges in the fix in #2377 to release 1.2.0.

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@nathancoleman @sarahalsmiller
api-gateway: fix cache and service deletion issue (#2377)
7497f56 
* Fix cache and service deletion issue

* Add comments

* add in acceptance test

* Fix indentation

* Fix unit test for deleting gateway w/ consul services

* Remove redundant service deregistration code

* Exit loop early once registration is found for service

* Fix import blocking

* Set status on pods added to test

* Apply suggestions from code review

* Reduce count of test gateways to 10 from 100

---------

Co-authored-by: Nathan Coleman <nathan.coleman@hashicorp.com>
Co-authored-by: Sarah Alsmiller <sarah.alsmiller@hashicorp.com>
@t-eckert t-eckert closed this Jun 15, 2023
@t-eckert t-eckert reopened this Jun 15, 2023
@t-eckert t-eckert changed the base branch from main to release/1.2.0 June 15, 2023 20:34
@t-eckert t-eckert added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport signals that a PR will not contain a backport label labels Jun 15, 2023
@t-eckert t-eckert marked this pull request as ready for review June 15, 2023 20:35
NicoletaPopoviciu
NicoletaPopoviciu approved these changes Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@NicoletaPopoviciu NicoletaPopoviciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, compared it w the original PR #2377

@t-eckert t-eckert merged commit 316c93e into release/1.2.0 Jun 15, 2023
@t-eckert t-eckert deleted the FIX-service-deregistration branch June 15, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicoletaPopoviciu NicoletaPopoviciu NicoletaPopoviciu approved these changes

@blake blake Awaiting requested review from blake

Assignees
No one assigned
Labels
pr/no-backport signals that a PR will not contain a backport label pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-eckert @NicoletaPopoviciu