Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Mw/net 4622 release 0.49.x acceptance tests broken missing packages into release/0.49.x #2422

Conversation

hc-github-team-consul-core

Backport

This PR is auto-generated from #2411 to be assessed for backporting due to the inclusion of the label backport/0.49.x.

The below text is copied from the body of the original PR.


Changes proposed in this PR:

  • This PR adds a configurable acceptance test matrix to the repo that can be fetched via the following make targets ( depending on the test):
    • make kind-test-packages
    • make aks-test-packages
    • make eks-test-packages
    • make gke-test-packages
  • Each branch can now have their own defined list of acceptance tests allowing branches to have different packages

How I've tested this PR:

How I expect reviewers to test this PR:
👀

Checklist:

  • Tests added
  • [n/a] CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/mw/NET-4622-Release-0.49.x-acceptance-tests-broken-missing-packages/humbly-smashing-rat branch from 17c3a0f to 5f86968 Compare June 22, 2023 16:23
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/mw/NET-4622-Release-0.49.x-acceptance-tests-broken-missing-packages/humbly-smashing-rat branch from 6ecfc91 to 9f2ba8d Compare June 22, 2023 16:23
@wilkermichael
Copy link
Contributor

wilkermichael commented Jun 22, 2023

See the last commit for the modification of the test matrix. I also removed the api-gateway no-op tests

- removed api-gateway no-op test
@wilkermichael wilkermichael force-pushed the backport/mw/NET-4622-Release-0.49.x-acceptance-tests-broken-missing-packages/humbly-smashing-rat branch from cd6491e to a26b723 Compare June 22, 2023 16:59
@@ -21,6 +21,6 @@ jobs:
with:
workflow: test.yml
repo: hashicorp/consul-k8s-workflows
ref: main
ref: mw/NET-4622-Release-0.49.x-acceptance-tests-broken-missing-packages
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget this!

@hc-github-team-consul-core hc-github-team-consul-core merged commit 3ef544d into release/0.49.x Jun 22, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/mw/NET-4622-Release-0.49.x-acceptance-tests-broken-missing-packages/humbly-smashing-rat branch June 22, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants