Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of feat(helm): add configurable server-acl-init and cleanup resource limits into release/1.0.x #2438

Conversation

hc-github-team-consul-core

Backport

This PR is auto-generated from #2416 to be assessed for backporting due to the inclusion of the label backport/1.0.x.

The below text is copied from the body of the original PR.


Changes proposed in this PR:

  • Exposes resource configuration for server-acl-init and sercer-acl-init-cleanup Jobs as helm values with existing defaults.

How I've tested this PR: unit tests

How I expect reviewers to test this PR: 👀

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/dans/NET-4256/helm-resource-values-for-server-acl-init/remarkably-rich-racer branch from 0cd799e to f692e43 Compare June 23, 2023 14:11
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/dans/NET-4256/helm-resource-values-for-server-acl-init/remarkably-rich-racer branch from 993ae24 to 74c47b2 Compare June 23, 2023 14:11
Copy link
Contributor

@DanStough DanStough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No modifications to cherry-picked commits.

@hc-github-team-consul-core hc-github-team-consul-core merged commit ffffd1b into release/1.0.x Jun 23, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/dans/NET-4256/helm-resource-values-for-server-acl-init/remarkably-rich-racer branch June 23, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants