Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of always update acl policy if it exists into release/0.49.x #2460

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #2392 to be assessed for backporting due to the inclusion of the label backport/0.49.x.

The below text is copied from the body of the original PR.


Changes proposed in this PR:

  • removed c.flagEnableNamespaces || c.flagSyncCatalog check to always allow acl update

Context :-
Between 0.49.0 and 1.0.x: we don't update ACL policies unless namespaces or sync catalog is enabled but between those versions, we merged controller and connect-inject. This meant we added required ACL rules to connect inject but those don't actually get updated and so now the controller can't do things like create intention CRDs.

How I've tested this PR:

  • deploy 0.49.x with connect inject enabled and acls enabled
  • Get the acl policy for connect injector and save it locally
  • build a control plane image and set imageK8s with it.
  • upgrade to 1.0.x with your changes
  • Check the acl policy again and check that it has updated rules as opposed to the one from step 2

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/aahel/always-update-acl-policies/multiply-lucky-vulture branch 2 times, most recently from bfa96e2 to 041ae4f Compare June 27, 2023 02:28
@hc-github-team-consul-core hc-github-team-consul-core enabled auto-merge (squash) June 27, 2023 02:28
@hc-github-team-consul-core hc-github-team-consul-core merged commit 2c51293 into release/0.49.x Jun 27, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/aahel/always-update-acl-policies/multiply-lucky-vulture branch June 27, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants