Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of Proxy Lifecycle helm, connect-inject and acceptance tests… #2482

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Backport of Proxy Lifecycle helm, connect-inject and acceptance tests… #2482

merged 1 commit into from
Jun 29, 2023

Conversation

wilkermichael
Copy link
Contributor

@wilkermichael wilkermichael commented Jun 28, 2023 •
edited
Loading

Changes proposed in this PR:

How I've tested this PR:

  • tests pass (CNI tests are broken so won't pass in any branches)

How I expect reviewers to test this PR:
👀

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@curtbushko @mikemorris
@ndhanushkodi @wilkermichael
Backport of Proxy Lifecycle helm, connect-inject and acceptance tests…
a19a035 
… into release/1.2.x (#2233)

* Proxy Lifecycle helm, connect-inject and acceptance tests (#2233)

Proxy Lifecycle helm, connect-inject and acceptance tests (#2233)

Co-authored-by: Nitya Dhanushkodi <nitya@hashicorp.com>

* disable lifecycle test

---------

Co-authored-by: Mike Morris <mikemorris@users.noreply.github.com>
Co-authored-by: Nitya Dhanushkodi <nitya@hashicorp.com>
Co-authored-by: Michael Wilkerson <mwilkerson@hashicorp.com>
@wilkermichael wilkermichael added pr/no-backport signals that a PR will not contain a backport label pr/no-changelog PR does not need a corresponding .changelog entry labels Jun 28, 2023
@wilkermichael wilkermichael merged commit d4c4afb into release/1.2.x Jun 29, 2023
@wilkermichael wilkermichael deleted the mw/manual-backport-proxy-lifecycle branch June 29, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashi-derek hashi-derek hashi-derek approved these changes

@t-eckert t-eckert Awaiting requested review from t-eckert

Assignees
No one assigned
Labels
pr/no-backport signals that a PR will not contain a backport label pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wilkermichael @hashi-derek @curtbushko