Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a -resolve-hostnames flag to the service-address command that
defaults to false. If true, any service with a hostname as its address
will have that hostname resolved and the first ip written.
If false, (default) the hostname will be written. Consul now supports hostnames for mesh gateway addresses so that's why we're adding this now.
This is useful in the case of EKS where load balancers have hostnames.
For WAN federation we want to use the hostname because the underlying
IPs can change. For ingress gateways this command is used to set the
address field in the service definition which only accepts IPs. This
flag allows the service-address command to be used so the service
registration is valid and then we document that in the EKS case users
shouldn't use the ingress consul DNS and should instead set up their own
DNS that resolves to the load balancer.