NET-5531 Translate response header modifier(s) from HTTPRoute onto Consul config entry #2904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathancoleman
added
pr/no-backport
nathancoleman
force-pushed
the
response-headers
branch
from
1ea3771 to
c92e491
Compare
nathancoleman
added
backport/1.2.x
jm96441n
reviewed
Sep 12, 2023
jm96441n
reviewed
Sep 12, 2023
| @@ -2,7 +2,10 @@ module github.com/hashicorp/consul-k8s/control-plane | |||
|
|
|||
| // TODO: remove when the SDK is released for Consul 1.17 | |||
| // The replace directive is needed be because `api` requires 0.14.1 of SDK and is both a direct and indirect dependency | |||
| replace github.com/hashicorp/consul/sdk v0.14.1 => github.com/hashicorp/consul/sdk v0.4.1-0.20230825164720-ecdcde430924 | |||
| replace ( | |||
| github.com/hashicorp/consul/proto-public v0.4.1 => github.com/hashicorp/consul/proto-public v0.1.2-0.20230911164019-a69e901660bd | |||
There was a problem hiding this comment.
is there a reason why we're adding a new replace here? if it's to work with an unreleased version should we update this comment as well?
There was a problem hiding this comment.
I just added a comment explaining the replace directive that I added as well as making the TODO more robust
jm96441n
approved these changes
Sep 12, 2023
Also use same pin for `sdk` that we're using for `api` and `proto-public`
2 tasks
nathancoleman
added
pr/no-backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Translate the
responseHeaderModifierthat already exists on the K8sHTTPRouteonto thehttp-routeconfig entry in Consul, which accepts response header modifiers as of hashicorp/consul#18646.This PR also addresses the fact that we write an empty header modifier to Consul today for request header modifications when the K8s
HTTPRoutedoes not specify any header modifications. Instead, we now appropriately write an empty list of header modifications to Consul when theHTTPRoutedoes not specify any.How I've tested this PR:
Create a K8s
HTTPRoutewith various response header modifier filter(s) and verify that the filter syncs into Consul and functions correctly. See video of my own testing.In addition, conformance tests exist here for this functionality that should pass where they previously failed. Here is the output of those tests passing.
How I expect reviewers to test this PR:
See above
Checklist: