-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(control-plane): v2 backoff on missing namespace #2960
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanStough
added
pr/no-changelog
PR does not need a corresponding .changelog entry
pr/no-backport
signals that a PR will not contain a backport label
labels
Sep 14, 2023
DanStough
force-pushed
the
dans/backoff-missing-v2-resources
branch
from
September 14, 2023 15:27
670f20c
to
fdb4841
Compare
DanStough
commented
Sep 14, 2023
DanStough
commented
Sep 14, 2023
DanStough
force-pushed
the
dans/backoff-missing-v2-resources
branch
from
September 14, 2023 15:37
fdb4841
to
529ddf4
Compare
zalimeni
approved these changes
Sep 14, 2023
wilkermichael
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great Dan!
Love all the retries 😍
Just some minor comments/questions
zalimeni
approved these changes
Sep 14, 2023
DanStough
force-pushed
the
dans/backoff-missing-v2-resources
branch
from
September 15, 2023 03:39
d41a28e
to
feb0349
Compare
thisisnotashwin
approved these changes
Sep 15, 2023
zalimeni
approved these changes
Sep 15, 2023
DanStough
force-pushed
the
dans/backoff-missing-v2-resources
branch
from
September 15, 2023 21:29
feb0349
to
de73cec
Compare
DanStough
force-pushed
the
dans/backoff-missing-v2-resources
branch
from
September 18, 2023 21:56
de73cec
to
4785ccc
Compare
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr/no-backport
signals that a PR will not contain a backport label
pr/no-changelog
PR does not need a corresponding .changelog entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR: Unit tests on the helper func, but not the controller. We have a task to come back to the enterprise tests. I'm also fine lumping that into this PR.
How I expect reviewers to test this PR: 👀
Checklist:
Tests addedCHANGELOG entry added